On Mon, 5 Jan 2026 at 17:39, Andre Vieira
<[email protected]> wrote:
>
> Hey Jonathan,
>
> I think you are the right person to review this? If not do you who might be?
I can't approve it, I think you want a C++ front-end maintainer (so
Jason or Nathan).
The patch looks ok, although I think it would be better to not rely on
IPv6, so that libcody can actually work on systems that don't support
it.
>
> Kind regards,
> Andre
>
> On 04/12/2025 15:04, Ross Burton wrote:
> > The module-mapper uses Cody::OpenInet6 to open the connection to the
> > host. However, some distributions (such as Ubuntu 24.04) only have a v4
> > address for localhost:
> >
> > $ grep localhost /etc/hosts
> > 127.0.0.1 localhost
> > ::1 ip6-localhost ip6-loopback
> >
> > On these systems this test fails with "Name or service not known", so
> > add that to the list of allowed error messages.
> > ---
> > gcc/testsuite/g++.dg/modules/bad-mapper-3.C | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/gcc/testsuite/g++.dg/modules/bad-mapper-3.C
> > b/gcc/testsuite/g++.dg/modules/bad-mapper-3.C
> > index 2a57956afc87..ca7eec2e1df5 100644
> > --- a/gcc/testsuite/g++.dg/modules/bad-mapper-3.C
> > +++ b/gcc/testsuite/g++.dg/modules/bad-mapper-3.C
> > @@ -1,6 +1,6 @@
> > // { dg-additional-options "-fmodules-ts
> > -fmodule-mapper=localhost:172477262" }
> > import unique3.bob;
> > -// { dg-error {failed (socket|connecting|disabled) mapper
> > 'localhost:172477262'} "" { target *-*-* } 0 }
> > +// { dg-error {failed (socket|connecting|disabled|Name or service not
> > known) mapper 'localhost:172477262'} "" { target *-*-* } 0 }
> > // { dg-prune-output "fatal error:" }
> > // { dg-prune-output "failed to read" }
> > // { dg-prune-output "compilation terminated" }
