On Tue, 6 Jan 2026 at 15:53, Keith Packard <[email protected]> wrote: > > From: Jonathan Wakely <[email protected]> > Date: Tue, 06 Jan 2026 15:11:21 +0000 > > > Are the copyright dates correct? Was this file based on an existing > > one? (If so, copying the dates from the original file is fine.) > > > Same question to all files with dates earlier than 2026. > > Yes, I copied all of these from os/newlib and made only trivial changes. > > > I don't think any of this cygwin-specific content is relevant to > > picolibc, right? So this should be am empty file (and doesn't need to > > be copyright 2000-2026, just 2026). > > Yeah, thanks. I was focused on fixing the ctype bugs; for the rest, > picolibc has been compatible enough with newlib to work fine. I'll wait > and see if there are more responses and send out another version in a > day or two. > > > >+#define _GLIBCXX_GTHREAD_USE_WEAK 0 > > > > This is the only one which might be relevant for your target, should > > this be defined to 0? If it should (or if it's not relevant because > > your target doesn't support gthreads anyway) you could just use > > os_include_dir=os/generic in configure.ac and not bother to add a > > custom os/picolibc/os_defines.h file at all. > > I need to replace the ctype code which lives in the same directory, so I > think I need to provide an empty os_defines.h file, just like qnx. I > haven't investigated gthread support, which would presumably depend upon > the specifics of the OS in use.
Ah yes, of course. You can't have ctype_inlines.h etc. coming from a different directory from os_defines.h because they both come from os_include_dir. OK, so you need a new os_defines.h even if it's empty.
