On Sun, Jan 11, 2026 at 07:06:28PM +0100, Stefan Schulze Frielinghaus wrote:
> On Sat, Jan 10, 2026 at 07:40:37PM +0100, Stefan Schulze Frielinghaus wrote:
> > On Sat, Jan 10, 2026 at 07:04:53PM +0100, Jakub Jelinek wrote:
> > > On Sat, Jan 10, 2026 at 05:24:15PM +0100, Stefan Schulze Frielinghaus 
> > > wrote:
> > > > libstdc++-v3/ChangeLog:
> > > > 
> > > >         * config/abi/post/s390x-linux-gnu/baseline_symbols.txt: Add
> > > >         names {,P,K}DF16.
> > > 
> > > This is wrong - an ABI issue.

BTW, if you didn't adjust the baseline_symbols.txt, the testsuite error
would tell you something wrong happened.
Guess I should verify the _Float*/__bf16 rtti symbols in all
baseline_symbols.txt from 13 to latest trunk to make sure other targets
haven't done the same thing.

> > > You can't export new symbols in CXXABI_1.3.14 symbol version when they
> > > weren't exported there in GCC 13.1 already.
> > > Symbols new in GCC 16 like these should be exported in CXXABI_1.3.17.
> > 
> > Yikes, you are absolutely right.  It was also wrong in the first draft I
> > posted back in Nov.  Thank you very much for double checking and
> > catching this!  I will trigger a full test run of your patch and come
> > back to you.
> 
> Bootstrap and regtest are successful for targets z16, z14, z13, z10,
> z900.

I've also bootstrapped/regtested it successfully on x86_64-linux and
i686-linux, plus verified the abilist before/after.

Though, I'm not sure if the patch falls under target maintainership, while
the code actually doesn't affect other targets, if it was buggy it would.

So I think we need Jonathan's ack.

        Jakub

Reply via email to