On Tue, 13 Jan 2026, Filip Kastl wrote:
> Whoops, I didn't replace all occurences of "pr" with "PR".  Here is a fix.

First of all thanks for the review, Alexander!

> +  <li><code>comment N</code> gets turned into a link to the <code>N</code>-th
> +    comment under <i>this</i> bug.</li>

<emph>this</emph> (since <i> is phyiscal, not logical markup).

> +  <li>Combining the two variants is also possible:
> +    <code>rN-M-gXXXXXXX</code> will link to
> +    <code>https://gcc.gnu.org/cgit/gcc/commit/?id=XXXXXXX</code>. So the
> +    <code>gXXXXXXX</code> takes precedence.  Note: You can use the script
> +    <code>contrib/git-descr.sh</code> from the GCC's source tree to convert
> +    commit hashes to this format.</li>

Do we need to document this last variant given it ignores some of its 
parameters? 

Or does contrib/git-descr.sh just create this format, hence we need to 
document this? (That script's documentation is a bit, um, minimal.)


The patch is fine. Thank you, Filip! 

(I have some minor suggestions, yet do not want to derail your submission, 
so may follow-up with a patch later on.)

Gerald

Reply via email to