Hi Jeff,
> On 1/16/2026 12:14 AM, Richard Biener wrote:
>> On Thu, Jan 15, 2026 at 9:51 PM Rainer Orth <[email protected]>
>> wrote:
>>> On FreeBSD/amd64, more than 700 tests FAIL like
>>>
>>> FAIL: gcc.dg/pch/common-1.c -O0 -g -I. -Dwith_PCH (test for excess errors)
>>> Excess errors:
>>> gcc/testsuite/gcc.dg/pch/common-1.c:1: sorry, unimplemented: PCH allocation
>>> failure
>>>
>>> This can easily be fixed by implementing the
>>> host_hooks.gt_pch_get_address hook. The code is shamelessly stolen from
>>> the openbsd implementation, only changing the names and omitting the
>>> hppa and i386 code. The former isn't supported by FreeBSD at all AFAIK,
>>> while the latter has just been removed in FreeBSD 15.0.
>>>
>>> Bootstrapped without regressions on x86_64-unknown-freebsd14.3: all PCH
>>> failures are gone.
>>>
>>> Ok for trunk?
>> OK. Is there possibly a PR about this?
> ?!? I thought I recently pushed a patch to fix PCH for NetBSD and OpenBSD
> from Kalvis:
>
> commit 1a2b5eeb5d24a44db9cb757906bd06912af15379
> Author: Kalvis Duckmanton <[email protected]>
> Date: Sun Jan 4 10:54:48 2026 -0700
[...]
> I missed FreeBSD obviously. But it would certainly be nice if all three
> impementations shared the same code.
you did. However, there was nothing to miss at that point because
nobody had bothered to add a FreeBSD implementation.
You're certainly right: the three BSDs are almost identical (and some
differences might even be unnecessary). However, I cannot do this
myself both for lack of time and test systems. I even tried to create
an OpenBSD VM on VirtualBox, but failed miserably at the time, unlike
FreeBSD.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
