With r16-5372-gfacb92812a4ec5 I have generalized reduction operator
support to allow (masked) internal functions in more cases.  The
following removes an now bogus assert given IFN_FMAX is now allowed
given IFN_COND_FMAX is available.

Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed.

        PR tree-optimization/123756
        * tree-vect-loop.cc (vect_transform_reduction): Remove
        bogus assert.

        * gcc.dg/vect/vect-pr123756.c: New testcase.
---
 gcc/testsuite/gcc.dg/vect/vect-pr123756.c | 9 +++++++++
 gcc/tree-vect-loop.cc                     | 7 ++-----
 2 files changed, 11 insertions(+), 5 deletions(-)
 create mode 100644 gcc/testsuite/gcc.dg/vect/vect-pr123756.c

diff --git a/gcc/testsuite/gcc.dg/vect/vect-pr123756.c 
b/gcc/testsuite/gcc.dg/vect/vect-pr123756.c
new file mode 100644
index 00000000000..46ca157f17b
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/vect/vect-pr123756.c
@@ -0,0 +1,9 @@
+/* { dg-do compile } */
+
+double
+foo (double m, float *ptr)
+{
+  for (int i = 0; i < 256; i++)
+    m = __builtin_fmax (m, ptr[i]);
+  return m;
+}
diff --git a/gcc/tree-vect-loop.cc b/gcc/tree-vect-loop.cc
index c8b9c6268c8..d3f9ffad52e 100644
--- a/gcc/tree-vect-loop.cc
+++ b/gcc/tree-vect-loop.cc
@@ -8233,11 +8233,8 @@ vect_transform_reduction (loop_vec_info loop_vinfo,
                                                 vop[2], vop[reduc_index]);
            }
          else
-           {
-             gcc_assert (code.is_tree_code ());
-             call = gimple_build_call_internal (cond_fn, 4, mask, vop[0],
-                                                vop[1], vop[reduc_index]);
-           }
+           call = gimple_build_call_internal (cond_fn, 4, mask, vop[0],
+                                              vop[1], vop[reduc_index]);
          new_temp = make_ssa_name (vec_dest, call);
          gimple_call_set_lhs (call, new_temp);
          gimple_call_set_nothrow (call, true);
-- 
2.51.0

Reply via email to