On Thu, 2026-01-22 at 11:06 -0600, Segher Boessenkool wrote: > Hi! > > On Wed, Jan 21, 2026 at 02:36:41AM -0600, Sangamesh Mallayya wrote: > > In AIX, build fails while trying to compile gcc/diagnostics/sarif- > > sink.cc. > > Here is the snapshot of the error we are getting. > > > > In file included from > > /opt/freeware/src/packages/BUILD/gcc/gcc/system.h:46, > > from > > /opt/freeware/src/packages/BUILD/gcc/gcc/diagnostics/sarif- > > sink.cc:34: > > /opt/freeware/lib/gcc/powerpc-ibm-aix7.3.0.0/13/include- > > fixed/stdio.h:593:12: error: conflicting declaration of C function > > 'int fgetpos64(FILE*, fpos64_t*)' > > 593 | extern int fgetpos64(FILE *, fpos64_t *); > > | ^~~~~~~~~ > > > > This happens when we include sys/types.h before defining > > _LARGE_FILES. > > > Including config.h before including sys/un.h should solve this > > error. > > > diff --git a/gcc/diagnostics/sarif-sink.cc b/gcc/diagnostics/sarif- > > sink.cc > > index 78743df7f1d..94db35ca864 100644 > > --- a/gcc/diagnostics/sarif-sink.cc > > +++ b/gcc/diagnostics/sarif-sink.cc > > @@ -18,6 +18,8 @@ You should have received a copy of the GNU > > General Public License > > along with GCC; see the file COPYING3. If not see > > <http://www.gnu.org/licenses/>. */ > > > > +#include "config.h" > > + > > #ifdef __MINGW32__ > > #include <winsock2.h> > > #include <afunix.h> > > @@ -26,7 +28,6 @@ along with GCC; see the file COPYING3. If not > > see > > #include <sys/socket.h> > > #endif > > > > -#include "config.h" > > #define INCLUDE_LIST > > #define INCLUDE_MAP > > #define INCLUDE_STRING > > This is okay for trunk. Thank you!
Sorry about breaking this, and thanks for the fix and reviews. Do you have push rights, or do you need someone to push this on your behalf? (I can do it if you like) Dave
