On Fri, 30 Jan 2026, Jakub Jelinek wrote:

> On Fri, Jan 30, 2026 at 04:14:59PM +0100, Richard Biener wrote:
> > The following avoids GCing IDENTIFIER_POINTERs referenced from
> > external_die_map after we clear ggc_protect_identifiers.  I never
> > expected those to be GCed.
> > 
> > LTO bootstrapped on x86_64-unknown-linux-gnu, testing in progress.
> > I'll wait for the reporter to confirm this fixes the observed
> > issue.
> > 
> > OK?
> > 
> >     PR debug/123886
> >     * dwarf2out.cc (sym_off_pair::sym): Remove GTY((skip)).
> 
> I wasn't even aware we have something like ggc_protect_identifiers.
> But given that it exists, if this works, guess it is ok.

Me neither - I remembered identifiers were not in GC memory...

Pushed.

Richard.

> 
>       Jakub
> 
> 

-- 
Richard Biener <[email protected]>
SUSE Software Solutions Germany GmbH,
Frankenstrasse 146, 90461 Nuernberg, Germany;
GF: Jochen Jaser, Andrew McDonald, Werner Knoblich; (HRB 36809, AG Nuernberg)

Reply via email to