On Tue, Sep 11, 2012 at 5:37 PM, Jakub Jelinek <ja...@redhat.com> wrote: > On Tue, Sep 11, 2012 at 05:29:12PM +0200, Paolo Carlini wrote: >> PS: slightly interesting, in a couple of cases - >> write_unnamed_type_name, wrap_cleanups_r - the parameters were >> actually used. > > Just a general comment, often an argument is only conditionally used, > e.g. depending on some preprocessor macro (e.g. target hook). In that > case unnamed parameter is not an option, but dropping ATTRIBUTE_UNUSED is > not desirable either.
And note that we have ARG_UNUSED for parameters - to cope with older compilers not handling attributes here too well (I run into this when using gcc 3.3 as host compiler). Richard. > Jakub
