Hi Iain,
>>> If it's just GCC that needs these redefined aliases, then it would be OK to
>>> wrap these around the version (GNU) condition, making it explicit that it's
>>> only for us.
>>>
>>> else version (Solaris)
>>> {
>>> version (GNU)
>>> alias int8_t = byte; ///
>>> else
>>> alias int8_t = char; ///
>>>
>>> Repeat for the others.
>>
>> At the moment that would certainly work, given that only GCC 16+ with
>> the fixinclude'd headers would have the signed char int8_t etc. Clang
>> doesn't know about them, and it's unclear how long it will take until
>> the change makes it into the Solaris headers.
>>
>
> Let's just do this then using version(GNU) to differentiate between GDC and
> others.
fine. I've adjusted the patch accordingly and retested as before.
> Don't mind who raises upstream pull request, I can write one up in a few
> minutes.
No worries: I've just done so myself:
Change int8_t etc. to signed char on Solaris#22582
https://github.com/dlang/dmd/pull/22582
I hope that's reasonable.
> (Obviously I can merge the pull immediately upon seeing it if you raise it)
Great, thanks.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
