On Thu, 20 Sep 2012, Georg-Johann Lay wrote: > Hans-Peter Nilsson wrote: > > Georg-Johann Lay wrote: > >> mode_dependent_address_p is not sensitive to the address space of the > >> passed > >> address. Thus, add an addr_space_t parameter to the hook. > > > > Borderline obvious. :) (J/k; the added functionality seems > > obvious but the implementation may have non-obvious issues, > > though I saw none.) > > What specifically?
Specifically "none"; nothing. (Not a typo for "one". :) > Being unsure about the component, I chose "other". > Is "middle-end" better? Since this is the back-end API, i think your "other" fits just as good or better. Just IMHO. > AFAIK "PR12345", "PR 12345" and "PR component/12345" entries are recognized > and connected to bugzilla PRs? If you're sure it gets through to bugzilla, then I certainly don't care. brgds, H-P
