On Mon, Oct 1, 2012 at 5:46 PM, Jonathan Wakely <jwakely....@gmail.com> wrote: > > static inline int > __gthread_recursive_mutex_destroy (__gthread_recursive_mutex_t > * UNUSED(__mutex)) > { > return 0; > } > > Is that indentation right? (the asterisk is in the same column as the > parameter type in a fixed-width font.)
When I see a single parameter that pushes past 80 columns, I normally start a new line after the left parenthesis and indent the next line 4 spaces. E.g.: static inline int __gthread_recursive_mutex_destroy ( __gthread_recursive_mutex_t * UNUSED(__mutex)) But I don't think there is any solid standard for this. > PR other/53889 > * gthr.h (__gthread_recursive_mutex_destroy): Document new required > function. > * gthr-posix.h (__gthread_recursive_mutex_destroy): Define. > * gthr-single.h (__gthread_recursive_mutex_destroy): Likewise. > * config/gthr-rtems.h (__gthread_recursive_mutex_destroy): Likewise. > * config/gthr-vxworks.h (__gthread_recursive_mutex_destroy): Likewise. > * config/i386/gthr-win32.h (__gthread_recursive_mutex_destroy): > Likewise. > * config/mips/gthr-mipssde.h (__gthread_recursive_mutex_destroy): > Likewise. > * config/pa/gthr-dce.h (__gthread_recursive_mutex_destroy): Likewise. > * config/s390/gthr-tpf.h (__gthread_recursive_mutex_destroy): > Likewise. The libgcc part of this is OK. Thanks. Ian