On Wed, Oct 03, 2012 at 03:26:14PM -0700, Mike Stump wrote: > On Oct 3, 2012, at 12:04 PM, Jason Merrill <ja...@redhat.com> wrote: > > This patch fixes a couple of Darwin issues I noticed with a cross-compiler: > > > > 1) Adds a couple of consts to avoid const-correctness errors. > > 2) Treats visibility "internal" like "hidden" rather than like "default". > > The documentation says that internal is hidden + processor-specific > > semantics, so treating it as just hidden makes sense to me. > > > > OK for trunk? > > Ok.
FYI, the x86_64-apple-darwin12 testsuite results with the proposed patch are at... http://gcc.gnu.org/ml/gcc-testresults/2012-10/msg00434.html It appears that the patch should also special case the "scan-assembler \\\\.internal.*Foo.methodEv" tests in g++.dg/ext/visibility/pragma-override1.C and g++.dg/ext/visibility/pragma-override2.C on darwin as well... FAIL: g++.dg/ext/visibility/pragma-override1.C -std=c++98 scan-assembler \\\\.internal.*Foo.methodEv FAIL: g++.dg/ext/visibility/pragma-override1.C -std=c++11 scan-assembler \\\\.internal.*Foo.methodEv FAIL: g++.dg/ext/visibility/pragma-override2.C -std=c++98 scan-assembler \\\\.internal.*Foo.methodEv FAIL: g++.dg/ext/visibility/pragma-override2.C -std=c++11 scan-assembler \\\\.internal.*Foo.methodEv Jack
