Alex Coplan (acoplan) <[email protected]> requested changes to the code:
We could probably do with a test for the deprecation warnings in the different
scenarios. Otherwise LGTM.
> +++ gcc/config/aarch64/aarch64.cc
> @@ -21079,2 +21083,4 @@
> {
> num_attrs++;
> +
> + if ((strcmp (token, "+tme") == 0) && !TARGET_TME)
Very minor nit, but the parens around strcmp aren't necessary. Could also be
more succint as:
```
if (!strcmp (token, "+tme") && !TARGET_TME)
```
but it's fine as is if you prefer, after all we don't expect this code to last
too long :)
--
https://forge.sourceware.org/gcc/gcc/pulls/186#issuecomment-6732
