On Wed, Oct 10, 2012 at 12:29:04PM +0200, Paolo Carlini wrote:
> Hi,
>
> On 10/03/2012 11:57 AM, Gopalasubramanian, Ganesh wrote:
> >Testing was done before posting the patch. It was successful.
> This change is now in:
>
> http://gcc.gnu.org/ml/gcc-cvs/2012-10/msg00418.html
>
> and it looks like is breaking the build for me:
>
> build/genattrtab
> /scratch/Gcc/svn-dirs/trunk/gcc/config/i386/i386.md
> insn-conditions.md \
> -Atmp-attrtab.c -Dtmp-dfatab.c -Ltmp-latencytab.c
> build/genautomata /scratch/Gcc/svn-dirs/trunk/gcc/config/i386/i386.md \
> insn-conditions.md > tmp-automata.c
> genautomata: automaton `bdver1_mult' is not declared
> genautomata: unit `bdver1-mult' is not used
Yeah, clearly a different version of the patch has been posted
vs. what has been checked in. The difference is removal of the
(define_cpu_unit "bdver1-mult" "bdver1_mult")
line (present in the posted patch, not in the checked in patch).
Also, the ChangeLog entry is wrong:
PR 51109
* gcc/config/i386/bdver1.md (bdver1_int): Automaton has been
split to reduce state transitions.
- should start with:
PR target/51109
* config/i386/bdver1.md
and really document the changes it has done, or just not contain
(bdver1_int) and document the file changes.
And Copyright year hasn't been updated (but this wasn't first
commit in 2012, others made the same mistake, no changes in 2011
btw).
Jakub
