On Mon, Oct 15, 2012 at 7:31 AM, Rainer Orth <r...@cebitec.uni-bielefeld.de> wrote: > Ian Lance Taylor <i...@google.com> writes: > >> On Fri, Oct 12, 2012 at 9:40 AM, Jakub Jelinek <ja...@redhat.com> wrote: >>> >>> I don't see how can their testcase be used if not converted to Dejagnu >>> though, most of their testcases are full of LLVM testcase markup >>> (// RUN, // CHECK*, etc.). So, if we import the library unmodified, >>> we'll need to setup some directory under gcc/testsuite/ for asan tests >>> and arrange for *.exp to find the libraries. >> >> Yes, that's more or less what the Go testsuite is like. I just have a >> complicated gcc/testsuite/go.test/go-test.exp that does the right >> thing to handle the Go test cases as DejaGNU test cases. > > I'd prefer if LLVM would accept the (sometimes more expressive and, to > GCC maintainers, well-known) Dejagnu annotations in addition to their > own ones, so the .exp files could live in the gcc tree only, while the > testcases themselves would be imported from upstream as is. > > The same holds for gcc/testsuite/go.*, btw.
In my opinion, supporting the full range of GCC testsuite annotations means imposing a lot of mechanism that the Go testsuite does not require. It would complicate the Go testsuite for no benefit. Anybody who can understand the GCC testsuite annotations can understand the much simpler Go testsuite annotations. Ian
