On Mon, Oct 15, 2012 at 11:39 PM, Wei Mi <w...@google.com> wrote:
>>
>> This is a good start. Can you send a patch out without including
>> libasan so at least the toplevel parts can be reviewed easier?
>> Also the changelog entry for gcc.c go under the gcc/ChangeLog rather
>> than the toplevel one.
>>
>> Thanks,
>> Andrew Pinski
>
> Sure, I attach it. Thanks for pointing out the changelog error.
+ %{fasan|coverage:-lasan -lpthread -ldl -lstdc++}\
Just curious, does asan runtime really require linking against pthread
and the standard C++ library?
Also I think the above will not work if shared libraries are disabled
as -lsupc++ is also needed when linking against the stdc++.
Also if libasan really depends on the C++ library, then most likely
you should a dependency in the toplevel makefile itself and maybe even
have the shared version of libasan link against libstdc++.
Thanks,
Andrew Pinski
>
> Thanks,
> Wei.
