On 10/08/12 17:46:03, Easwaran Raman wrote: > I have attached a revised patch. The updated ChangeLog is given below > and I have responded to your comments inline: > > 2012-10-08 Easwaran Raman <era...@google.com> > * optabs.c (emit_cmp_and_jump_insn_1): Add a new parameter to > specificy the probability of taking the jump.
Typo above: specificy > * except.c (sjlj_emit_function_enter): Pass probability to > emit_cmp_and_jump_insns. On some targets (e. g., IA64), the following patch leads to an unused variable warning-as-error: > Index: except.c > =================================================================== > --- except.c (revision 191879) > +++ except.c (working copy) > @@ -1161,13 +1161,7 @@ sjlj_emit_function_enter (rtx dispatch_label) > > emit_cmp_and_jump_insns (x, const0_rtx, NE, 0, > TYPE_MODE (integer_type_node), 0, > - dispatch_label); > - last = get_last_insn (); > - if (JUMP_P (last) && any_condjump_p (last)) > - { > - gcc_assert (!find_reg_note (last, REG_BR_PROB, 0)); > - add_reg_note (last, REG_BR_PROB, GEN_INT (REG_BR_PROB_BASE / 100)); > - } > + dispatch_label, REG_BR_PROB_BASE / 100); > #else > expand_builtin_setjmp_setup (plus_constant (Pmode, XEXP (fc, 0), > sjlj_fc_jbuf_ofs), [...] gcc-trunk/src/gcc/except.c:1156:14: error: unused variable ‘last’ [-Werror=unused-variable] rtx x, last; ^ cc1plus: all warnings being treated as errors