On 22/10/12 12:50, Terry Guo wrote:
Hi,Attached patch intends to fix bug 55019 which is exposed on 4.7 branch. Although this bug can't be reproduced on trunk, I think this fix is still useful to make trunk more robust. Tested with trunk regression test on cortex-m0 and cortex-m3, no regression found. Also tested with various benchmark like Dhrystone/coremark/eembc_v1 on cortex-m0, no regression on performance and code size. Is it ok to go upstream and 4.7 branch? BR, Terry gcc/ChangeLog 2012-10-22 Terry Guo <terry....@arm.com> PR target/55019 * config/arm/arm.c (thumb1_expand_prologue): Don't push high regs with live argument regs. gcc/testsuite/ChangeLog 2012-10-22 Terry Guo <terry....@arm.com> PR target/55019 * gcc.target/arm/pr55019.c: New.= thumb1-argument-register-issue.patch N¬n‡r¥ªíÂ)emçhÂyhi×¢w^™©Ý
The test isn't thumb1 specific. In fact, it isn't even ARM specific. So I think it should be moved to gcc.dg.
Otherwise OK for trunk and 4.7. R.
