Hi, > >> I think tree-ssa-loop-ivopts is simply > >> asking for the wrong thing, and needs to be changed. As I say, > >> Sandra had some fixes in this area. > > > > This patch: > > > > http://gcc.gnu.org/ml/gcc-patches/2012-06/msg00319.html > > > > Sadly, that patch has fallen off the bottom of my priority list (some > > legal wrangling halted all work on the Hexagon port that was the > > motivating example for it), and meanwhile it's become bit-rotten due to > > Bill Schmidt's work that touched on the ivopts code as well. If someone > > else would like to "adopt" this patch, please do! > > > > I agree that it is just plain dumb for ivopts to be trying to precompute > > address costs for modes that are not even valid. > > > > Zdenek, > > this patch prevents ivopts from passing VOIDmode to address_cost. > > The patch fixes a buildbreaker in newlib for mips16. I've confirmed that I can > do a full mips build with newlib with this patch. > > I've bootstrapped and reg-tested this patch on x86_64. > > OK for trunk (without the assert)? > > Thanks, > - Tom > > 2012-11-14 Tom de Vries <t...@codesourcery.com> > > * tree-ssa-loop-ivopts.c (get_use_type): New function. > (get_computation_at): Use get_use_type. > (get_computation_cost_at): Declare and set mem_mode. Use mem_mode.
OK, Zdenek