On Tue, 2012-11-20 at 11:07 +0400, Konstantin Serebryany wrote: > I've applied your patch (with minor style and comment changes) upstream: > http://llvm.org/viewvc/llvm-project?view=rev&revision=168356 > I did not have any way to test it though. Also, gmail does something > horrible with patches inlined in a message, so I might have missed > something.
Doing a quick peruse through your LLVM commit, I see you grabbed the PopStackFrames() addition, but the asan_linux.cc changes do not include the call to PopStackFrames() after the _Unwind_Backtrace() call. Specifically, the following patch hunk: > _Unwind_Backtrace(Unwind_Trace, stack); > > + // Pop off the two ASAN functions from the backtrace. > > + stack->PopStackFrames(2); I'll scan the reset of your commit looking for anything else that is missing. > Soon I hope to learn how to pull the upstream changes to gcc tree and > do it myself. > (http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55376) > In the meantime, you are welcome to apply the same patch to gcc manually. > Same for the gcc-specific parts of you patch. I'll grab your changes from the LLVM tree so as to pick up your style changes and add anything you inadvertently dropped and commit it. Thanks. Peter
