On Fri, 2012-12-07 at 13:37 -0600, Richard Henderson wrote: > On 2012-12-06 02:25, Andreas Krebbel wrote: > > ! targetm.canonicalize_comparison ((int*)&compare_code, &op0, &op1, 1); > > The basic approach seems sound. But this cast is distinctly uncool. > > And why the unused return value? If you didn't need it, why add it? > > > r~
For the SH part, can't the 'sh_canonicalize_comparison_1' just be named 'sh_canonicalize_comparison' and have it overload the target hook function? Cheers, Oleg
