Hello Jakub, Please see my responses below. Thanks,
Balaji V. Iyer. > -----Original Message----- > From: Jakub Jelinek [mailto:ja...@redhat.com] > Sent: Friday, December 14, 2012 11:59 AM > To: Iyer, Balaji V > Cc: gcc-patches@gcc.gnu.org > Subject: Re: [PATCH][Cilkplus] Fix pragma simd info being lost > > On Fri, Dec 14, 2012 at 04:59:02AM +0000, Iyer, Balaji V wrote: > > --- tree-vect-loop.c (revision 194483) > > +++ tree-vect-loop.c (working copy) > > @@ -234,8 +234,8 @@ > > if (flag_enable_cilk && pragma_simd_assert_requested_p > > (loop->pragma_simd_index)) > > { > > - error ("Loop not vectorized. " > > - "Exiting as requested by Pragma SIMD"); > > + fatal_error ("Loop not vectorized. " > > + "Exiting as requested by Pragma SIMD"); > > } > > return false; > > } > > Why do you think fatal_error is the right thing here? Why doesn't normal > error > work? Generally, if one function contains 10 #pragma simd loops that require > vectorization and 5 out of them aren't vectorized, it is nicer for users to > be told > about all 5 of them, rather than just the first one. > fatal_error will exit immediately. The #pragma simd assert requires the compiler to halt compilation if the loop is not vectorized. This is why I used fatal_error. The default case is noassert. > > Jakub