On 01/15/2013 09:16 AM, David Blaikie wrote:
> & now with an actual GCC patch, instead of the GDB one - sorry about that.
>
> On Tue, Jan 15, 2013 at 8:31 AM, David Blaikie <dblai...@gmail.com> wrote:
>> The regex to detect the beginning of a test file execution was too
>> broad, matching any line beginning with "Running ". This caused
>> dg-extract-results.sh to truncate some test logs, including
>> gdb.base/help.exp in the GDB test suite (which tests "help running",
>> printing "Running the program.")
>>
>> The attached patch makes the match a little more precise to avoid
>> this. With this the exact count of PASS/FAIL/etc lines in the
>> dg-extract-results.sh output matches the counts in the computed
>> summary exactly for all cases I've seen.
>>
>> I encountered this in the GDB test suite but was asked to submit the
>> change upstream to GCC as GDB would prefer to avoid unnecessary local
>> changes to the script & this change seems general enough to go in to
>> GCC.
>>
>> I'm still a little fuzzy on the specifics of ChangeLog lines, but
>> here's my attempt at one for this change:
>>
>> * dg-extract-results.sh: constrain the start-of-log pattern to
>> avoid accidentally matching test content
OK. I checked it in, with this ChangeLog entry:
2013-01-15 David Blaikie <dblai...@gmail.com>
* dg-extract-results.sh: Constrain the start-of-log pattern.
Janis
