> -----Original Message----- > From: Vladimir Makarov [mailto:vmaka...@redhat.com] > Sent: Thursday, April 11, 2013 7:20 AM > To: Bin Cheng > Cc: gcc-patches@gcc.gnu.org > Subject: Re: [PATCH GCC/pr56124] Don't prefer memory if the source of load > operation has side effect > > On 13-04-06 11:16 PM, Bin Cheng wrote: > > > >> -----Original Message----- > >> From: gcc-patches-ow...@gcc.gnu.org > >> [mailto:gcc-patches-ow...@gcc.gnu.org] > > On > >> Behalf Of Bin Cheng > >> Sent: Monday, March 25, 2013 3:15 PM > >> To: gcc-patches@gcc.gnu.org > >> Subject: FW: [PATCH GCC/pr56124] Don't prefer memory if the source of > >> load operation has side effect > >> > >> Sorry for the wrong list. > >> > >> -----Original Message----- > >> From: Bin Cheng [mailto:bin.ch...@arm.com] > >> Sent: Monday, March 25, 2013 3:00 PM > >> To: g...@gcc.gnu.org > >> Subject: [PATCH GCC/pr56124] Don't prefer memory if the source of > >> load operation has side effect > >> > >> Hi, > >> As reported in PR56124, IRA causes redundant reload by preferring to > >> put pseudo which is target of loading in memory. Generally this is > >> good but > > the > >> case in which the src of loading has side effect. > >> This patch fixes this issue by checking whether source of loading has > >> side effect. > >> > >> I tested the patch on x86/thumb2. Is it OK? Thanks. > >> > >> 2013-03-25 Bin Cheng <bin.ch...@arm.com> > >> > >> PR target/56124 > >> * ira-costs.c (scan_one_insn): Check whether the source rtx of > >> loading has side effect. > > Ping. > This patch is ok for trunk. Thanks. And sorry, for the delay with the answer. > Committed as r197691.
Thanks.
