At 2013-04-30 18:45:42,"Matthew Gretton-Dann" <matthew.gretton-d...@linaro.org> wrote: > Hi, > > On 08/04/13 06:28, Xinyu Qi wrote: > > At 2013-04-02 17:50:03,"Ramana Radhakrishnan" <ramra...@arm.com> > wrote: > >> On 04/02/13 10:40, Xinyu Qi wrote: > >>> Hi, > >>> According to Vladimir Makarov's analysis, the root cause of PR > target/54338 is that ALL_REGS doesn't contain IWMMXT_GR_REGS in > REG_CLASS_CONTENTS. > >>> It seems there is no reason to exclude the IWMMXT_GR_REGS from > ALL_REGS as IWMMXT_GR_REGS are the real registers. > >>> This patch simply makes ALL_REGS include IWMMXT_GR_REGS to fix > this PR. > >>> Since the test case gcc.target/arm/mmx-2.c would fail for the same > reason and become pass with this fix, no extra test case need to be add. > >>> Pass arm.exp test. Patch attached. > >> > >> Testing just with arm.exp is not enough. > >> > >> Ok if no regressions running the entire regression testsuite for C > >> and > >> C++ for arm*-*-*eabi with an iwmmxt configuration. > > > > Hi Ramana, > > > > I run the full dejagnu test with -march=iwmmxt2 specified in the whole > progress for this patch. > > No regression but a lot of new pass found in the test. > > Please help to commit it. > > > > ChangeLog > > > > 2013-04-02 Xinyu Qi <x...@marvell.com> > > > > PR target/54338 > > * config/arm/arm.h (REG_CLASS_CONTENTS): Include > IWMMXT_GR_REGS in ALL_REGS. > > It looks to me as if this should also be applied to the 4.8 branch - Xinyu do > you > agree?
Hi Matt, I'm OK with the patch applied to the 4.8 branch. (But I only tested the patch for the trunk.) Thanks, Xinyu > > If so is the backport OK for 4.8? > > Thanks, > > Matt > > > -- > Matthew Gretton-Dann > Toolchain Working Group, Linaro