On Fri, May 3, 2013 at 10:28 AM, David Edelsohn <dje....@gmail.com> wrote: > On Fri, May 3, 2013 at 1:26 PM, Jeff Law <l...@redhat.com> wrote: >> On 05/03/2013 11:15 AM, Teresa Johnson wrote: >>> >>> On Fri, May 3, 2013 at 9:37 AM, David Edelsohn <dje....@gmail.com> wrote: >>>> >>>> Thanks for the patch. >>>> >>>> Bootstrap works on x86 and Anton's testcase works on x86. >>>> >>>> Is there any testcase for x86 that would demonstrate the failure or >>>> that could check the probabilities in a dump file and see the >>>> inconsistency? >>> >>> >>> Patch is committed. But I just figured out why it isn't showing up on >>> x86 - it is because -fschedule-insns is not enabled by default. I can >>> reproduce it with x86 using the same test case. Will go ahead and >>> submit a patch to add this to the testsuite. >> >> Just an FYI, we don't use -fschedule-insns (first pass) on x86/x86_64 due to >> register pressure issues. However, I think for the testsuite it'd be OK to >> have a test which uses -fschedule-insns to expose the need for clamping on >> the probabilities. > > Then Anton's testcase would make a good addition, with explicit > -fschedule-insns.
Yep, getting that patch ready right now. Teresa > > Thanks, David -- Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413