On 05/17/2013 01:25 AM, Jakub Jelinek wrote: > +(define_peephole2 > + [(set (match_operand:SI 0 "memory_operand") > + (match_operand:SI 1 "register_operand")) > + (set (match_operand:SI 2 "register_operand") (match_dup 1)) > + (parallel [(set (match_dup 2) > + (ashiftrt:SI (match_dup 2) > + (match_operand:QI 3 "const_int_operand"))) > + (clobber (reg:CC FLAGS_REG))]) > + (set (match_operand:SI 4 "memory_operand") (match_dup 2))] > + "INTVAL (operands[3]) == 31
No sense in using match_operand in the pattern and INTVAL == 31 in the condition when you can just use (const_int 31) in the pattern. Modulo those two cases, the patch is ok. r~
