> -----Original Message-----
> From: Jakub Jelinek [mailto:ja...@redhat.com]
> Sent: Thursday, May 23, 2013 3:04 PM
> To: Iyer, Balaji V
> Cc: Richard Henderson; 'Joseph S. Myers'; 'Aldy Hernandez'; 'gcc-patches'
> Subject: Re: [PING]RE: [patch] cilkplus: Array notation for C patch
>
> On Thu, May 23, 2013 at 06:27:04PM +0000, Iyer, Balaji V wrote:
> > gcc/testsuite/ChangeLog
> > 2013-05-23 Balaji V. Iyer <balaji.v.i...@intel.com>
> >
> > * gcc.dg/cilk-plus/array_notation/compile/array_test2.c: New test.
>
> I have concerns about the test locations, to me this looks way too deep tree,
> whether something is a compile test, or compile test expecting errors or
> runtime
> test is easily determined by { dg-do compile } vs. { dg-do run } and presence
> or
> lack of { dg-error ... } comments. So IMHO that level should be left out,
> plus I'd
> say the array_notation/ level is unnecessary as well, just put everything
> into c-
> c++-common/cilk-plus/an-*.c (except for tests that aren't going to be usable
> for
> C++, those can stay in gcc.dg/cilk-plus/an-*.c). Then gcc.dg/cilk-plus/*.exp
> would just ensure that tests from that directory are run and also from c-c++-
> common/ and later on the same would happen in g++.dg/cilk-plus/. In the
> future when you will need to link against runtime library cilk-plus.exp would
> just
> arrange for that to be added to LD_LIBRARY_PATH, -L.../ etc.
Hi Jakub & Aldy,
There are a couple reasons why I picked this hierarchy. I looked at
gcc-c-torture directory and it has compile, execute etc. This is why I had
execute, compile and errors directory. Also, we are planning to have some
hybrid tests that will add array notation + cilk keywords, array notation +
pragma simd, etc. Yes, I can see the deeply buried issue, but I once had long
file names (~25-30 characters) that tells what kind of tests (when we first
opened the branch) they are and someone in the mailing list complained that the
file names were long and suggested that I use directories instead. If it is OK
with you both I would like to keep this hierarchy
Thanks,
Balaji V. Iyer.
>
> > * gcc.dg/cilk-plus/array_notation/compile/array_test1.c: Ditto.
> > * gcc.dg/cilk-plus/array_notation/compile/array_test_ND.c: Ditto.
> > * gcc.dg/cilk-plus/array_notation/compile/builtin_func_double.c:
> > Ditto.
> > * gcc.dg/cilk-plus/array_notation/compile/builtin_func_double2.c:
> > Ditto.
> > * gcc.dg/cilk-plus/array_notation/compile/gather_scatter.c: Ditto.
> > * gcc.dg/cilk-plus/array_notation/compile/if_test.c: Ditto.
> > * gcc.dg/cilk-plus/array_notation/compile/sec_implicit_ex.c: Ditto.
> > * gcc.dg/cilk-plus/array_notation/errors/decl-ptr-colon.c: Ditto.
> > * gcc.dg/cilk-plus/array_notation/errors/dimensionless-arrays.c:
> > Ditto.
> > * gcc.dg/cilk-plus/array_notation/errors/fn_ptr.c: Ditto.
> > * gcc.dg/cilk-plus/array_notation/errors/fp_triplet_values.c: Ditto.
> > * gcc.dg/cilk-plus/array_notation/errors/gather-scatter.c: Ditto.
> > * gcc.dg/cilk-plus/array_notation/errors/misc.c: Ditto.
> > * gcc.dg/cilk-plus/array_notation/errors/parser_errors.c: Ditto.
> > * gcc.dg/cilk-plus/array_notation/errors/parser_errors2.c: Ditto.
> > * gcc.dg/cilk-plus/array_notation/errors/parser_errors3.c: Ditto.
> > * gcc.dg/cilk-plus/array_notation/errors/parser_errors4.c: Ditto.
> > * gcc.dg/cilk-plus/array_notation/errors/rank_mismatch.c: Ditto.
> > * gcc.dg/cilk-plus/array_notation/errors/rank_mismatch2.c: Ditto.
> > * gcc.dg/cilk-plus/array_notation/errors/rank_mismatch3.c: Ditto.
> > * gcc.dg/cilk-plus/array_notation/errors/sec_implicit.c: Ditto.
> > * gcc.dg/cilk-plus/array_notation/errors/sec_implicit2.c: Ditto.
> > * gcc.dg/cilk-plus/array_notation/errors/sec_reduce_max_min_ind.c:
> > Ditto.
> > * gcc.dg/cilk-plus/array_notation/errors/tst_lngth.c: Ditto.
> > * gcc.dg/cilk-plus/array_notation/errors/vla.c: Ditto.
> > * gcc.dg/cilk-plus/array_notation/execute/an-if.c: Ditto.
> > * gcc.dg/cilk-plus/array_notation/execute/array_test1.c: Ditto.
> > * gcc.dg/cilk-plus/array_notation/execute/array_test2.c: Ditto.
> > * gcc.dg/cilk-plus/array_notation/execute/array_test_ND.c: Ditto.
> > * gcc.dg/cilk-plus/array_notation/execute/builtin_fn_custom.c:
> > Ditto.
> > * gcc.dg/cilk-plus/array_notation/execute/builtin_fn_mutating.c:
> > Ditto.
> > * gcc.dg/cilk-plus/array_notation/execute/builtin_func_double.c:
> > Ditto.
> > * gcc.dg/cilk-plus/array_notation/execute/builtin_func_double2.c:
> > Ditto.
> > * gcc.dg/cilk-plus/array_notation/execute/comma_exp.c: Ditto.
> > * gcc.dg/cilk-plus/array_notation/execute/conditional.c: Ditto.
> > * gcc.dg/cilk-plus/array_notation/execute/exec-once.c: Ditto.
> > * gcc.dg/cilk-plus/array_notation/execute/exec-once2.c: Ditto.
> > * gcc.dg/cilk-plus/array_notation/execute/gather_scatter.c: Ditto.
> > * gcc.dg/cilk-plus/array_notation/execute/if_test.c: Ditto.
> > * gcc.dg/cilk-plus/array_notation/execute/n-ptr-test.c: Ditto.
> > * gcc.dg/cilk-plus/array_notation/execute/sec_implicit_ex.c: Ditto.
> > * gcc.dg/cilk-plus/array_notation/execute/side-effects-1.c: Ditto.
> > * gcc.dg/cilk-plus/array_notation/execute/test_builtin_return.c:
> > Ditto.
> > * gcc.dg/cilk-plus/array_notation/execute/test_sec_limits.c: Ditto.
> > * gcc.dg/cilk-plus/array_notation/execute/cilkplus_AN_c_execute.exp:
> > New script.
> > * gcc.dg/cilk-plus/array_notation/compile/cilkplus_AN_c_compile.exp:
> > Ditto.
> > * gcc.dg/cilk-plus/array_notation/errors/cilkplus_AN_c_errors.exp:
> > Ditto.
>
> Jakub
