On Jun 19, 2013, at 1:38 AM, Richard Biener <richard.guent...@gmail.com> wrote: > On Wed, Jun 19, 2013 at 9:22 AM, Jakub Jelinek <ja...@redhat.com> wrote: >> On Wed, Jun 19, 2013 at 11:12:21AM +0400, Igor Zamyatin wrote: >>> Right, as you did for other cases. It works here as well. >> >> Patch preapproved. > > I wonder how much code breaks these days when we enable -fno-common by > default?
Not much. gcc as Apple shipped it, has always been no-common, and indeed the shared library scheme doesn't like common. There are a few test cases that would need -fcommon, but I don't think that is a big deal. Most oss I think is -fno-common friendly. I think gcc should default to c99, and I think c99 mode (and later) could use -fno-common by default. For pre c99 modes, I'd probably just leave it to the dust bin of history.
