Alexander Ivchenko <aivch...@gmail.com> writes: > Hi Joseph, thanks for your comments. > > I updated the patch: > > 1) The function name as a second argument in libc_has_function target > hook was removed - was not usefull so far. > 2) By using contrib/config-list.mk (thanks for the hint - great tool!) > and analysing tm.h files and what is included in them I have checked > 197 targets. That analysis includes all issues that you raised in your > comments - everything is fixed now. I don't like that sometimes we > have to redefine the version of the hook back to the default one due > to a poisoning of including elfos.h, but I couldn't find a better > solution - I commented all those cases. > > Regtesting is in progress now. I have already tested the patch before, > so I don't expect to see any new problems. > > If all the tests pass, is the patch OK for trunk?
Unfortunately, this patch broke Solaris 10+ bootstrap; it cannot have been tested properly there: In file included from ./tm.h:27:0, from /vol/gcc/src/hg/trunk/local/gcc/gencheck.c:23: /vol/gcc/src/hg/trunk/local/gcc/config/sol2-10.h:21:4: error: "/*" within comment [-Werror=comment] /* /* Solaris 10 has the float and long double forms of math functions. ^ cc1plus: all warnings being treated as errors make[3]: *** [build/gencheck.o] Error 1 Fixed as follows; bootstrapped without regressions on i386-pc-solaris2.10, installed on mainline. Rainer 2013-08-21 Rainer Orth <r...@cebitec.uni-bielefeld.de> * config/sol2-10.h (TARGET_LIBC_HAS_FUNCTION): Don't nest comment.
diff --git a/gcc/config/sol2-10.h b/gcc/config/sol2-10.h --- a/gcc/config/sol2-10.h +++ b/gcc/config/sol2-10.h @@ -18,7 +18,7 @@ You should have received a copy of the G along with GCC; see the file COPYING3. If not see <http://www.gnu.org/licenses/>. */ -/* /* Solaris 10 has the float and long double forms of math functions. +/* Solaris 10 has the float and long double forms of math functions. We redefine this hook so the version from elfos.h header won't be used. */ #undef TARGET_LIBC_HAS_FUNCTION #define TARGET_LIBC_HAS_FUNCTION default_libc_has_function
-- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University