On Thu, Aug 29, 2013 at 6:20 PM, David Malcolm <dmalc...@redhat.com> wrote:
>         * gimple.c (gt_ggc_mx (gimple)): New, as required by GTY((user)).
>         (gt_pch_nx (gimple)): Likewise.

GIMPLE isn't supposed to end up in a PCH. Can you please make this
function simply call gcc_unreachable()?

FWIW 1: I really think all these hand-written markers aren't a good
idea, we should really figure out a way to have automatic marker
function generators, something less complex than gengtype, of course.
But to have all these calls to the type-mangled marker functions
(gt_pch_n_9tree_node, etc.) is going to be a problem in the long term.

It seems to me that the first step in all these conversions to
hand-written markers should be to make gengtype spit out the marker
functions *without* the type name mangling, i.e. all marker functions
should just be gt_ggc_mx(type) / gt_pch_nx(type).

Ciao!
Steven

Reply via email to