On Aug 30, 2013, at 4:22 PM, Diego Novillo <dnovi...@google.com> wrote:
> Thanks for the suggestions. I've incorporated them into the patch.
> It now adds tree-core.h with all the structures, enums, typedefs and
> some fundamental declarations from tree.h. Everything else stays in
> tree.h for now.
So, the comments for the data structures that moved, should also move?!
The below moves one comment that I noticed.
Ok?
Index: tree-core.h
===================================================================
--- tree-core.h (revision 202238)
+++ tree-core.h (working copy)
@@ -1328,6 +1328,11 @@ struct GTY(()) tree_decl_non_common {
tree vindex;
};
+/* FUNCTION_DECL inherits from DECL_NON_COMMON because of the use of the
+ arguments/result/saved_tree fields by front ends. It was either inherit
+ FUNCTION_DECL from non_common, or inherit non_common from FUNCTION_DECL,
+ which seemed a bit strange. */
+
struct GTY(()) tree_function_decl {
struct tree_decl_non_common common;
Index: tree.h
===================================================================
--- tree.h (revision 202238)
+++ tree.h (working copy)
@@ -2534,11 +2534,6 @@ extern vec<tree, va_gc> **decl_debug_arg
#define DECL_FINAL_P(NODE)\
(FUNCTION_DECL_CHECK (NODE)->decl_with_vis.final)
-/* FUNCTION_DECL inherits from DECL_NON_COMMON because of the use of the
- arguments/result/saved_tree fields by front ends. It was either inherit
- FUNCTION_DECL from non_common, or inherit non_common from FUNCTION_DECL,
- which seemed a bit strange. */
-
/* The source language of the translation-unit. */
#define TRANSLATION_UNIT_LANGUAGE(NODE) \
(TRANSLATION_UNIT_DECL_CHECK (NODE)->translation_unit_decl.language)
