On Fri, Sep 13, 2013 at 07:18:24PM +0000, Joseph S. Myers wrote:
> On Fri, 13 Sep 2013, Marek Polacek wrote:
>
> > This is kind of fugly, but don't have anything better at the moment.
> > 2013-09-13 Marek Polacek <[email protected]>
> >
> > PR sanitizer/58413
> > c-family/
> > * c-ubsan.c (ubsan_instrument_shift): Don't instrument
> > an expression if we can prove it is correct.
>
> Shouldn't the conditions used here for an expression being proved correct
> match those for instrumentation, i.e. depend on flag_isoc99 and on
> (cxx_dialect == cxx11 || cxx_dialect == cxx1y)?
I don't think so: for the unsigned case we could restrict it to C
only, but it doesn't hurt doing it even for C++; in the signed case
we care only about C, but we can't restrict it to flag_isoc99 only,
since we need to prove the correctnes even for ANSI C.
Marek
