> On Wed, Sep 18, 2013 at 10:57:57AM +0200, Richard Biener wrote: > > On Wed, 18 Sep 2013, Richard Earnshaw wrote: > > > > > On 16/09/13 15:13, Richard Biener wrote: > > > > +void > > > > +get_range_info (tree name, double_int &min, double_int &max, > > > > + enum value_range_type &range_type) > > > > > > > > I'm not sure we want to use references. Well - first time. > > > > > > Personally, I don't think we should ever allow non-const references. > > > Use of references means you can't tell from the source code that an > > > argument to a function can be modified. It leads to confusion and makes > > > things harder to debug.
I use non-const references in ipa-devirt code and speculative indirect call removal. I am not thrilled by them, just it seems common in C++ source bases. If we don't want them, i will remove these (they are used on two or three places, so it is easy) Honza > > > > That's a good argument, so please make get_range_info take pointers > > to min/max/range_type. > > Or return range_type and just take min/max pointers? > > Jakub
