On 10/18/2013 12:53 AM, Oleg Endo wrote: > Hi, > > On Thu, 2013-10-17 at 16:13 +0200, Christian Bruel wrote: >> Hello, >> >> This patch just reorganizes the SH code used for memory builtins into >> its own file, in preparation of the RTL strcmp hoisting in the next part. >> > Since GCC is now being compiled as C++, it's probably better to name > newly added source files .cc instead of .c. Could you please rename the > new file to sh-mem.cc? > > Thanks, > Oleg Hello Oleg,
I have no objection to rename a pure C file to a c++ suffixed file. I'll conform to whatever the general guidelines for pure C code is. For now it doesn't seem to be the tendency. grep -i "ew File" ChangeLog | grep .c: * gimple-builder.c: New File. * config/winnt-c.c: New file * ipa-profile.c: New file. * ubsan.c: New file. * ipa-devirt.c: New file. * vtable-verify.c: New file. * config/arm/aarch-common.c: ... here. New file. * diagnostic-color.c: New file. * config/linux-android.c: New file. I haven't seen any reference to this in the GCC coding guidelines, should we prefer .cc, cxx, C, cpp., c++.. ? Also I'm wondering if there is any plan to rename all files in the tree so we have a consistent source tree. Do we have general recommendation from the general maintainers ? Many thanks Christian