On Tue, Nov 5, 2013 at 10:07 AM, Peter Bergner <berg...@vnet.ibm.com> wrote: > On Tue, 2013-11-05 at 09:57 -0600, Peter Bergner wrote: >> On Tue, 2013-11-05 at 08:19 +0100, Jakub Jelinek wrote: >> > Note, not even glibc itself includes <asm/stat.h>, so the chances of that >> > header actually working for you are low. glibc instead just defines the >> > structures itself for each of the architectures. >> >> I have to agree, including kernel header files is always frowned upon >> and very risky. Jakub, do you think we should be doing the same thing >> here that glibc does, namely having libsanitizer defining its own >> structures? > > One other problem is the use of __old_kernel_stat in the libsanitizer > sources. The PPC64 kernel was created after the change to the current > stat, so it doesn't define __old_kernel_stat since it never had one.
In fact, we do define our own structures. Kernel headers are limited to one or two files just to verify that our definitions are binary compatible. __old_kernel_stat issue must be solvable with a reasonable amount of #ifdefs.
