On Fri, Nov 8, 2013 at 10:46 PM, Jeff Law wrote: > Also note that other patches have gone in recently which include those files > for exactly the same reason.
I assume you're referring to tree-ssa-reassoc.c? It's the only new one I could find since I cleaned rtl.h out from almost all tree-* files last year. > I don't think Andrew did anything wrong here. Yup. The problem came in with an ARM patch: http://gcc.gnu.org/r174578 > Clearly those can/should/will go away when BRANCH_COST turns into a target > hook. I'd like to do it myself, but I'm buried right now. Hook would be better but even as a macro this can be solved, see the patch I attached up thread. There should be a ban, enforced somehow, on new #includes of rtl.h and expr.h in GIMPLE passes... Ciao! Steven
