söndag 17 november 2013 22.37.08 skrev  Magnus Granberg:
> lördag 16 november 2013 20.37.58 skrev  Ryan Hill:
> > On Wed, 13 Nov 2013 23:28:45 +0100
> > 
> > Magnus Granberg <zo...@gentoo.org> wrote:
> > > Hi
> > > This patchset will add a new configure options --enable-default-pie.
> > > With the new option enable will make it pass -fPIE and -pie from the gcc
> > > and g++ frontend. Have only add the support for two targets but should
> > > work on more targes. In configure.ac we add the new option. We can't
> > > compile the compiler or the crt stuff with -fPIE it will brake the PCH
> > > and the crtbegin and crtend files. The disabling is done in the
> > > Makefiles. The needed spec is added to DRIVER_SELF_SPECS. We disable all
> > > the profiling test for the linking will fail.Tested on x86_64 linux
> > > (Gentoo).
> > > 
> > > /Magnus Granberg
> > 
> > Hey Magnus.  Some nits:
> ......
> 
> > > +for C, C++, ObjC, ObjC++, if none of @option{-fno-PIE},
> > > @option{-fno-pie},
> > > +@option{-fPIC}, @option{-fpic}, @option{-fno-PIC}, @option{-fno-pic},
> > > +@option{-nostdlib}, @option{-nostartfiles}, @option{-shared},
> > > +@option{-nodefaultlibs}, nor @option{static} are found.
> > 
> > Looks like nodefaultlibs is missing from PIE_DRIVER_SELF_SPECS or this
> > needs to be updated.
> > 
> > Thanks!
> 
> Thankyou for the nits. Have updated the patches with the fixes.
> The same changlog should work in my first post about this new option.
> 
> >Mike Stump wrote
> >Ick.  Would be nice to figure out on what systems one can do this and just
> >do it without the configure option.  Is there some reason that we need an
> >option for it?
> 
> It would work well on most *-*-linux* targets but i don't have all the
> hardware for testing and I agre with Ian that it should not be default
> enable.
> 
> /Magnus Granberg
Can some one review the patches and commit if it look sane?

/Magnus Granberg

Reply via email to