On 11/21/2013 03:07 PM, Jeff Law wrote:
On 11/21/13 13:04, Andrew MacLeod wrote:
On 11/21/2013 02:26 PM, Jeff Law wrote:
On 11/21/13 11:15, Andrew MacLeod wrote:
Is there anything in particular one needs to do for plugins? I
thought I
saw a patch somewhere that changed something in the Makefile, but
don't
know if that is actually required since I never did that for any of
the
others. Any plugin which used gimple.h probably needs a few more
includes...
We need to make sure the header files that are needed by plugins
appear in Makefile.in::PLUGIN_HEADERS so that they get installed in a
place where plugins can find them.
stupid question perhaps, but aren't most header files a potential
plugin header? Why don't we just install them all...
I think that's basically what's happened in the past, we just
installed everything, or close to everything.
One way to find out would be to look at the set of .h files from
gcc-4.8/gcc and look at what ultimately ends up in PLUGIN_HEADERS. I
bet they're pretty damn close :-)
No one has complained yet, but in theory any .h I split up over the
past couple of months has the potential to be required... maintaining
that macro in Makefile.in seems kinda lame now that we don't maintain
the macros for building. I'm sure its rotted already.
I wouldn't expect much fallout until after we started putting release
candidates out there. That doesn't mean we should wait until then to
address the problem though ;-)
Of course it does :-) If its a big enough issue, then maybe we fix it
better :-)
Anyway, I'll add this to the patch...
Im going to recheck out trunk and rebuild and compare stuff, I'm getting
weird spurious issues after I updated. Probably be tomorrow sometime
before I manage the checkin.
Andrew
* Makefile.in (PLUGIN_HEADERS): Add flattened gimple.h includes.
Index: Makefile.in
===================================================================
*** Makefile.in (revision 205213)
--- Makefile.in (working copy)
*************** installdirs:
*** 3103,3109 ****
$(mkinstalldirs) $(DESTDIR)$(man7dir)
PLUGIN_HEADERS = $(TREE_H) $(CONFIG_H) $(SYSTEM_H) coretypes.h $(TM_H) \
! toplev.h $(DIAGNOSTIC_CORE_H) $(BASIC_BLOCK_H) $(GIMPLE_H) $(TREE_PASS_H)
$(GCC_PLUGIN_H) \
$(GGC_H) $(TREE_DUMP_H) $(PRETTY_PRINT_H) $(OPTS_H) $(PARAMS_H) \
$(tm_file_list) $(tm_include_list) $(tm_p_file_list) $(tm_p_include_list) \
$(host_xm_file_list) $(host_xm_include_list) $(xm_include_list) \
--- 3103,3111 ----
$(mkinstalldirs) $(DESTDIR)$(man7dir)
PLUGIN_HEADERS = $(TREE_H) $(CONFIG_H) $(SYSTEM_H) coretypes.h $(TM_H) \
! toplev.h $(DIAGNOSTIC_CORE_H) $(BASIC_BLOCK_H) pointer-set.h
$(HASH_TABLE_H) \
! tree-ssa-alias.h $(INTERNAL_FN_H) gimple-fold.h tree-eh.h gimple-expr.h \
! gimple.h is-a.h $(TREE_PASS_H) $(GCC_PLUGIN_H) \
$(GGC_H) $(TREE_DUMP_H) $(PRETTY_PRINT_H) $(OPTS_H) $(PARAMS_H) \
$(tm_file_list) $(tm_include_list) $(tm_p_file_list) $(tm_p_include_list) \
$(host_xm_file_list) $(host_xm_include_list) $(xm_include_list) \
