On 11/22/2013 09:15 AM, Richard Sandiford wrote:
> I have a patch to upgrade most genrecog warnings into errors.  This patch
> fixes one for bfin about {push,pop}_multiple_operation not being defined
> at the .md level.
> 
> Tested by building bfin-elf with the warnings turned to errors, and by
> comparing the before and after assembly output at -O2 for gcc.c-torture,
> gcc.dg and g++.dg.  OK to install?

> +extern int push_multiple_operation_p (rtx);
> +extern int pop_multiple_operation_p (rtx);

I was once told that functions with side effects shouldn't be called _p,
and these ones set up some global variables. But you can check it in
either this way or with a different name.


Bernd

Reply via email to