Oleg Endo <oleg.e...@t-online.de> wrote:
> Currently GCC doesn't pass the --isa parameter to the assembler for SH
> targets other than SH2A and SH5.  This makes the assembler accept any
> kind of ISA and happily produce e.g. SH2A code even though the target is
> SH4, which will then fail to link.
> The attach patch fixes this by passing the --isa parameter also for -m1,
> -m2*, -m3*, and -m4*.
> It also caught a mistake in libgcc/crt1.S, where the SH3 / SH4 VBR setup
> code was compiled for SH2E.
> 
> Tested with
>  make -k -j4 check RUNTESTFLAGS="--target_board=sh-sim
> \{-m2/-ml,-m2/-mb,-m2a/-mb,-m4/-ml,-m4/-mb,-m4a/-ml,-m4a/-mb}"
> 
> and no new failures.
> OK for trunk?

libgcc fix should be an independent patch and is OK for trunk
as an obvious fix.  --isa part looks fine but is a new feature.
It's OK when trunk goes back to stage1.

Regards,
        kaz

Reply via email to