Hi Richard, Pinging for further comments.
regards, Venkat. On 27 November 2013 14:24, Venkataramanan Kumar <venkataramanan.ku...@linaro.org> wrote: > Hi Richard, > >> I don't think it's good to have long lists of targets on generic tests. >> Can we factor this out into a target-supports option? > > I have updated the patch as per your recommendation. Please let me > know if it is fine. > > 2013-11-26 Venkataramanan Kumar <venkataramanan.ku...@linaro.org> > * configure.ac (gcc_cv_libc_provides_tls_ssp): Add test to > check TLS support in target C library for Aarch64. > * configure: Regenerate. > * config.in: Regenerate. > * config/aarch64/aarch64.md (stack_protect_set, stack_protect_test) > (stack_protect_set_<mode>, stack_protect_test_<mode>): Add > initial machine description for Stack Smashing Protector. > * config/aarch64/aarch64-linux.h (TARGET_THREAD_SSP_OFFSET): Define. > > 2013-11-26 Venkataramanan Kumar <venkataramanan.ku...@linaro.org> > * lib/target-supports.exp > (check_effective_target_stack_protection): New procedure. > * g++.dg/fstack-protector-strong.C: Add target check for > stack protection. > * gcc.dg/fstack-protector-strong.c: Likewise. > > regards, > Venkat. > > > On 26 November 2013 20:23, Richard Earnshaw <rearn...@arm.com> wrote: >> On 26/11/13 14:16, Venkataramanan Kumar wrote: >>> Index: gcc/testsuite/gcc.dg/fstack-protector-strong.c >>> =================================================================== >>> --- gcc/testsuite/gcc.dg/fstack-protector-strong.c (revision 205378) >>> +++ gcc/testsuite/gcc.dg/fstack-protector-strong.c (working copy) >>> @@ -1,6 +1,6 @@ >>> /* Test that stack protection is done on chosen functions. */ >>> >>> -/* { dg-do compile { target i?86-*-* x86_64-*-* rs6000-*-* s390x-*-* } } */ >>> +/* { dg-do compile { target i?86-*-* x86_64-*-* rs6000-*-* s390x-*-* >>> aarch64-*-* } } */ >>> /* { dg-options "-O2 -fstack-protector-strong" } */ >>> >> >> I don't think it's good to have long lists of targets on generic tests. >> Can we factor this out into a target-supports option? >> >> R. >>