On Tue, Oct 29, 2013 at 7:56 AM, Andrew Pinski <andrew.pin...@caviumnetworks.com> wrote: > Hi, > The problem here is that both asan and ubsan testsuite test if we > have set a library path before running the testsuite. This is > incorrect when running the already installed testing as there is no > path to set. > > This patch changes it so it tests if the executable is able to be > built/linked before running the tests. This also fixes a > warning/error in restoring the CXXFLAGS which shows up in the already > installed testing case. > > OK? Bootstrapped and tested on x86_64-linux-gnu. Also manually > looked into the log file to make sure both asan and ubsan were still > being tested.
Ping. This patch has been outstanding for over a month now. Thanks, Andrew > > Thanks, > Andrew Pinski > > ChangeLog: > * lib/ubsan-dg.exp (check_effective_target_fundefined_sanitizer): New > function. > (ubsan_init): Save off ALWAYS_CXXFLAGS. > (ubsan_finish): Restore ALWAYS_CXXFLAGS correctly. > * lib/asan-dg.exp (check_effective_target_faddress_sanitizer): Change > to creating an executable. > (asan_init): Save off ALWAYS_CXXFLAGS. > (asan_finish): Restore ALWAYS_CXXFLAGS correctly. > * gcc.dg/ubsan/ubsan.exp: Don't check the return value of ubsan_init. > Check check_effective_target_fundefined_sanitizer before running the > tests. > * g++.dg/ubsan/ubsan.exp: Likewise. > * testsuite/gcc.dg/asan/asan.exp: Don't check > check_effective_target_faddress_sanitizer too early. Don't check the > return value of asan_init. > * g++.dg/asan/asan.exp: Likewise.
