On 12/20/13 10:25, Jakub Jelinek wrote:
So it probably should be checked
in combine_reaching_defs instead where you have already both the registers
in the right modes available and can call reg_overlap_mentioned_p on them
directly. One argument would be SET_DEST (def_insn) and one SET_DEST
(cand->insn), right?
Certainly my preference is to have all the tests for this exception live
in combine_reaching_defs.
We actually need to test in the widened mode, so we have to generate a
new reg expressing SET_DEST (def_insn) in the widened mode. The other
argument for the reg_overlap_mentioned_p call is SET_DEST (cand->insn).
I find myself wondering if we should be using the widened mode register
for the calls to reg_{used,set}_between_p calls. I'll have to ponder
that for a few minutes.
jeff
