Committed. I will prepare some new tests as you suggested. Thanks, Bingfeng
-----Original Message----- From: Jakub Jelinek [mailto:ja...@redhat.com] Sent: 23 December 2013 14:53 To: Bingfeng Mei Cc: gcc-patches@gcc.gnu.org; H.J. Lu (hjl.to...@gmail.com) Subject: Re: [PATCH] Fix PR59569 On Mon, Dec 23, 2013 at 02:23:49PM +0000, Bingfeng Mei wrote: > Thanks for suggestion. Please find attached patch. GCC is bootstrapped and > passes testsuite on x86-64. Let me know if it is OK to commit. Ok, thanks. Would be nice to add runtime testcases for both cases (test whether vectorization with negative step storing a constant worked properly, and similarly for external def (e.g. function parameter with __attribute__((noinline, noclone)) on the function), but that can be done as a follow-up patch. Jakub