On Thu, Jan 16, 2014 at 06:13:33PM +0000, James Greenhalgh wrote: > On Thu, Jan 16, 2014 at 05:14:24PM +0000, Richard Earnshaw wrote: > > On 16/01/14 16:15, Alan Lawrence wrote: > > > This is a small patch that makes the -mcpu, -march and -mtune > > > command-line options case-insensitive, allowing e.g. -mcpu=Cortex-A15 > > > -march=ARMv7. > > > > > > Regression tested on arm-none-eabi with no issues; options passed onto > > > e.g. ld are always lowercase (as previously). > > > > > > OK for trunk? > > > > > > --Alan > > > > > > ChangeLog: > > > * config/arm/arm.opt: Make -mcpu, -march, -mtune case-insensitive. > > > > * config/arm/arm.opt (mcpu, march, mtune): Make case-insensitive. > > > > Don't forget the leading tab; and since someone else will have to commit > > the patch for you, you should also include the date/author part as well. > > Generally > > > > <date> Alan Lawrence <alan.lawre...@arm.com> > > > > would be acceptable, since the commit date may not be the same as the > > posting date. > > > > Otherwise, this is OK. > > > > I've committed this to trunk on Alan's behalf as revision 206673, > with the following Changelog: > > 2014-01-16 Alan Lawrence <alan.lawre...@arm.com> > > * config/arm/arm.opt: Make -mcpu, -march, -mtune case-insensitive. >
A more careful reading of your review of Alan's patch shows that this should have been: 2014-01-16 Alan Lawrence <alan.lawre...@arm.com> * config/arm/arm.opt (mcpu, march, mtune): Make case-insensitive. I've fixed this up in revision 206700. Sorry for the noise. James