Re: [PATCH][AArch64] Vector shift by 64 fix

[Alex Velenko]

On 06/01/14 11:52, Alex Velenko wrote:

Hi,

This patch fixes vector shift by 64 behavior to meet reference
manual expectations. Testcase included to check that expectations
are now met. No regressions found.

Is patch OK?

Thanks,
Alex

2014-01-06  Alex Velenko  <alex.vele...@arm.com>

gcc/

     * config/aarch64/aarch64-simd-builtins.def (ashr): DI mode removed.
     (ashr_simd): New builtin handling DI mode.
     * config/aarch64/aarch64-simd.md (aarch64_ashr_simddi): New pattern.
     (aarch64_sshr_simddi): New match pattern.
     * config/aarch64/arm_neon.h (vshr_n_s32): Builtin call modified.
     (vshrd_n_s64): Likewise.
     * config/aarch64/predicates.md (aarch64_shift_imm64_di): New
predicate.

gcc/testsuite/

     * gcc.target/aarch64/sshr64_1.c: New testcase.

Ping!

Hi,
Can someone, please, review the patch.
Kind regards,
Alex