Mikael,
Je t'en remercie!
That must be one of the fastest reviews on record!
Committed as revision 207389
4.7 and 4.8 to follow next weekend.
Paul
On 1 February 2014 19:28, Mikael Morin <mikael.mo...@sfr.fr> wrote:
> Le 01/02/2014 18:57, Paul Richard Thomas a écrit :
>> Dear All,
>>
>> This regression was flagged by Harald and the trigger, r158683, was
>> identified by HJ. Many thanks to both. It surprises me that the bug
>> has lain dormant for so long.
>>
>> The fix is fortunately relatively simple. CHARACTER scalars are, in
>> fact arrays in one shape or form and so using them as an SS_REFERENCE
>> is bound to fail unless a pointer to the array is stored in the outer
>> loop and passed to the ELEMENTAL subroutine/function.
>> gfc_conv_string_parameter is equipped to convert CHARACTERs in all
>> their manifestations into a pointer, so I have used this. It does not
>> work correctly for function results, so this case has been excluded.
>>
>> Not only does this patch bootstrap and regtest on FC17/x86_64 but all
>> the tests in ISO_VARYING_STRING run correctly. This latter is
>> important because the suite makes heavy use of elemental functions
>> with character arguments.
>>
>> OK for trunk and, with a decent delay, 4.7 and 4.8?
>>
> Yes, thanks.
>
> Mikael
--
The knack of flying is learning how to throw yourself at the ground and miss.
--Hitchhikers Guide to the Galaxy
