On Wed, Feb 5, 2014 at 5:11 PM, Jakub Jelinek <ja...@redhat.com> wrote:

>> > gcc.target/i386/avx512f-vrndscaless-2.c currently FAILs on Solaris 9/x86
>> > with gas:
>> >
>> > FAIL: gcc.target/i386/avx512f-vrndscaless-2.c (test for excess errors)
>> > Excess errors:
>> > /vol/gcc/src/hg/trunk/local/gcc/testsuite/gcc.target/i386/avx512f-vrndscaless-2.
>> > c:21:14: warning: incompatible implicit declaration of built-in function 
>> > 'floorf
>> > ' [enabled by default]
>> > /vol/gcc/src/hg/trunk/local/gcc/testsuite/gcc.target/i386/avx512f-vrndscaless-2.
>> > c:24:14: warning: incompatible implicit declaration of built-in function 
>> > 'ceilf'
>> >  [enabled by default]
>> >
>> > The platform lacks C99 support, but this can easily be avoided by using
>> > the builtins instead.  The following patch does just that; tested
>> > with the appropriate runtest invocation on i386-pc-solaris2.9 and
>> > x86_64-unknown-linux-gnu.
>>
>> Let's solve this in the way sse4_1-floorf-vec.c solves it and simply add
>>
>> extern float floorf (float);
>
> Won't that break if math.h defines floorf as a macro?
> You'd at least need then
> extern float (floorf) (float);

Looks like using builtins should be the correct way, so the original
patch is OK.

Rainer, can you please add the same cure to sse4_1-floor*.vec tests?

Thanks,
Uros.

Reply via email to